Handle error in capture_str#756
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Aug 17, 2021
Merged
Conversation
ElianHugh
approved these changes
Aug 17, 2021
Collaborator
ElianHugh
left a comment
There was a problem hiding this comment.
Works as expected, thank you for the quick fix!
ElianHugh
pushed a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Handle error in capture_str * Simplify capture_str
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #755
capture_strnow handles error internally in the following way:str()with user specifiedmax.level.(If you do not have screenshot) How can I check this pull request?
The following examples no longer produce errors:
Simple flawed
str:Original issue with flawed
strimplementation: