Fix issues with c() in function args#751
Merged
renkun-ken merged 2 commits intoREditorSupport:masterfrom Aug 15, 2021
Merged
Conversation
Uses the match pattern for functions from the textmate R grammar
Contributor
|
As I wrote in the comment #713 (comment), do you need to remove the link to the R-Box which is already archived? |
Collaborator
Author
|
Thanks for the reminder! I've removed the statement, as modifications to the syntax should be made here anyway |
ElianHugh
added a commit
to ElianHugh/vscode-R
that referenced
this pull request
May 12, 2022
* Fixes REditorSupport#713 Uses the match pattern for functions from the textmate R grammar * Remove old rbox message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the match pattern for functions from the textmate R grammar in place of the previous function pattern. I don't have experience with using textmate grammar, but from testing on my code I haven't seen any issues thus far. If anyone is more knowledgeable with textmate and would like to chime in, that would be greatly appreciated :)
The grammar's repo indicates that there shouldn't be any licensing issues either.
What problem did you solve?
Fixes #713 and incidentally #120.
How can I check this pull request?
The following should not have issues with text decoration when using the PR.