Repository navigation
fix: preserve previous settings when saving fails - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed save can destroy the last valid
settings.json: the previous implementation opened the destination in write mode before serialization, so a serialization exception left the old file empty. A partial write could likewise leave invalid JSON.Serialize first, write to a temporary file in the destination directory, close it, and replace the destination only after the write completes. Clean up the temporary file if writing or replacement fails. This preserves the previous file on ordinary save failures; it does not claim durability across power loss.
Add seven persistence tests covering existing-file replacement, failed serialization (with and without an old file), partial-write failure, replacement failure, first save, and Unicode. Both serialization regressions fail against the original implementation. All 15 lightweight tests now pass locally, including the existing request tests.
The CI workflow now runs the complete lightweight suite on Python 3.11 and 3.13. It installs python-dotenv alongside the existing test dependencies. Ruff check/format for the changed test file, source lint, Compose configuration, and
git diff --checkpass.Tests use temporary directories and injected failures. No real credentials, model assets, running inference, or paid APIs are used. Prepared with OpenAI Codex assistance.