Skip to content

chore(core): wrap two over-width cancellation assertions #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 1 commit into from
Sep 7, 2026
Merged

chore(core): wrap two over-width cancellation assertions #11232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core/src/core/coreToolScheduler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13373,7 +13373,9 @@ describe('CoreToolScheduler telemetry spans', () => {
expect(completedCall.status).toBe('cancelled');
expect(completedCall.response.executionStatus).toBe('cancelled');
const responseText = JSON.stringify(completedCall.response.responseParts);
expect(responseText).toContain('User intentionally cancelled this tool call.');
expect(responseText).toContain(
'User intentionally cancelled this tool call.',
);
expect(responseText).not.toContain('had already completed');
});

Expand All @@ -13392,7 +13394,9 @@ describe('CoreToolScheduler telemetry spans', () => {
expect(completedCall.response.executionStatus).toBe('cancelled');
const responseText = JSON.stringify(completedCall.response.responseParts);
expect(responseText).toContain('The tool had already completed');
expect(responseText).not.toContain('User intentionally cancelled this tool call. Stop');
expect(responseText).not.toContain(
'User intentionally cancelled this tool call. Stop',
);
});

// A post-execution cancellation drops the model-visible output, but the
Expand Down
Loading