Use another style guide?

[modocache]

How about we just use https://github.com/github/swift-style-guide or https://github.com/raywenderlich/swift-style-guide? That way someone else can do all the work of maintaining it, and we just have to follow it. 😉

I prefer the GitHub one.

[sharplet]

Just had a read, and it looks pretty good. I especially like the bit about 2-space indent, but that's probably impractical for this org. 😉

Speaking of which, we should probably add something about indentation settings being set explicitly in the Xcode project, so that contributors don't accidentally commit code with their potentially different personal indentation settings.

One other thing — I think the one about protocol conformance in separate extensions may be fine for application targets, but I think for framework authors it's problematic due to not being able to export public extensions in a module.

[paulyoung]

I basically follow the GitHub one anyway 👍

[modocache]

I especially like the bit about 2-space indent, but that's probably impractical for this org.

I wouldn't be opposed to doing two giant pull requests to get Quick and Nimble in conformance with whatever we decide on.

Speaking of which, we should probably add something about indentation settings being set explicitly in the Xcode project, so that contributors don't accidentally commit code with their potentially different personal indentation settings.

Definitely!

One other thing...

Yeah, I think the best approach here is to put a link to an existing style guide, plus a few bullet points for exceptions. I'm pretty opposed to maintaining our own style guide (why reinvent the wheel?). Thoughts, @jeffh? Heck, we could even use the Pivotal Labs style guide, provided it's public. 😉

[jeffh]

Sure, the github style guide works for me. 👍