Add more localizations and proof read app.id.arb#538
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e15802b. Configure here.
| "settingsResetCautionBullet3": "Tanpa frasa pemulihan, dana Anda hilang selamanya", | ||
| "settingsResetCautionCheckbox": "Saya sudah mencadangkan frasa pemulihan saya", | ||
| "settingsResetCautionBullet2": "Dana Anda tetap di blockchain, hanya recovery phrase yang dapat memulihkan akses", | ||
| "settingsResetCautionBullet3": "Tanpa recovery phrase, wallet Anda hilang selamanya", |
There was a problem hiding this comment.
Indonesian reset warning contradicts funds
Medium Severity
The updated settingsResetCautionBullet3 says the user's wallet is lost forever without a recovery phrase, while the preceding bullet on the same screen states funds remain on the blockchain and only the phrase restores access. English and the prior Indonesian copy warn about permanent loss of funds/access, not the wallet object, which misstates the risk during reset.
Reviewed by Cursor Bugbot for commit e15802b. Configure here.
| "multisigApprovalsOf": "{count} von {threshold}", | ||
| "multisigApproveConfirmTitle": "Bist du sicher?", | ||
| "multisigApproveConfirmBody": "Du bist dabei, eine Übertragung zu genehmigen über", | ||
| "multisigApproveConfirmTo": "an {address}", |
There was a problem hiding this comment.
German approve confirm dangling über
Low Severity
multisigApproveConfirmBody ends with “über” while multisigApproveConfirmTo is “an {address}”, mirroring English “transfer of” plus amount plus “to {address}”. The German line reads like an incomplete “approve a transfer over …” and does not align with the amount and recipient layout, producing confusing confirmation copy for German users.
Reviewed by Cursor Bugbot for commit e15802b. Configure here.
|
Do we really need this? I am not really in favor of adding features unless required, minimal is best |
|
More translation slows down my development, more tokens, more changes for every UX change We should do this at the end when the app is settled, not now |
|
So I think we need to pause this |
|
Okay, we can pause then until we are on mainnet and focus more on User Experience than blockchain features. |
2 participants
Summary
Note
Low Risk
Copy-only and generated localization files; no auth, transaction, or business-logic changes.
Overview
Expands mobile app localization from en + id to de, en, hi, id, ru, zh by adding full
app_de.arb/app_hi.arb(and matching generatedAppLocalizationsDe/AppLocalizationsHiclasses) and wiring them inapp_localizations.dart(supportedLocales,lookupAppLocalizations,isSupported).Indonesian (
app_id.arb) strings are proofread—mostly wallet onboarding, multisig proposal labels, and wallet-reset caution copy—for clearer wording (e.g. recovery phrase, co-owned multisig, “active” vs “past” proposals).No runtime logic changes beyond Flutter picking up the new locale delegates already used by
MaterialApp.supportedLocales.Reviewed by Cursor Bugbot for commit e15802b. Configure here.