fix(multisig): await creation submission before navigating away#528
Closed
n13 wants to merge 1 commit into
Closed
Conversation
Multisig creation previously fire-and-forgot the submit (unawaited), so the UI navigated Home before the network accepted the extrinsic, unlike the normal transfer flow. startMultisigCreation now awaits the submit and the returned extrinsic hash before completing; only finalization polling stays in the background. On submit failure it clears the pending record and rethrows so AddMultisigScreen surfaces the error inline and stays put instead of optimistically navigating.
Collaborator
Author
|
not what I had in mind, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unawaited), so the UI navigated Home before the network accepted the extrinsic — inconsistent with the normal transfer flow (which waits for the RPC hash, see wait for RPC hash before showing success screen #524).startMultisigCreationnow awaitssubmitCreateMultisigExtrinsicand the returned extrinsic hash before completing. Only finalization polling stays in the background.AddMultisigScreensurfaces the error inline via its existing error toaster and stays on screen instead of optimistically navigating. This replaces the asynchronoussubmitFailedtoast with synchronous error handling at the call site.Test plan
flutter analyzeclean (verified).