Skip to content

fix(multisig): await creation submission before navigating away#528

Closed
n13 wants to merge 1 commit into
mainfrom
fix/multisig-create-await-submit
Closed

fix(multisig): await creation submission before navigating away#528
n13 wants to merge 1 commit into
mainfrom
fix/multisig-create-await-submit

Conversation

@n13

@n13 n13 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Multisig creation previously fire-and-forgot the submit (unawaited), so the UI navigated Home before the network accepted the extrinsic — inconsistent with the normal transfer flow (which waits for the RPC hash, see wait for RPC hash before showing success screen #524).
  • startMultisigCreation now awaits submitCreateMultisigExtrinsic and the returned extrinsic hash before completing. Only finalization polling stays in the background.
  • On submit failure it removes the pending creation record and rethrows, so AddMultisigScreen surfaces the error inline via its existing error toaster and stays on screen instead of optimistically navigating. This replaces the asynchronous submitFailed toast with synchronous error handling at the call site.

Test plan

  • Create a multisig with sufficient balance → screen waits until the tx hash returns, then navigates Home; pending creation continues tracking to finalization.
  • Force a submit failure (e.g. offline) → error toaster shown, stays on Add Multisig screen, pending record cleared, button re-enabled.
  • Insufficient balance / already-exists preflight → specific error toasters unchanged.
  • flutter analyze clean (verified).

Multisig creation previously fire-and-forgot the submit (unawaited), so
the UI navigated Home before the network accepted the extrinsic, unlike
the normal transfer flow. startMultisigCreation now awaits the submit and
the returned extrinsic hash before completing; only finalization polling
stays in the background. On submit failure it clears the pending record
and rethrows so AddMultisigScreen surfaces the error inline and stays put
instead of optimistically navigating.
@n13

n13 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

not what I had in mind, closing

@n13 n13 closed this Jun 15, 2026
@dewabisma dewabisma deleted the fix/multisig-create-await-submit branch June 22, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant