Skip to content

Some fixes#500

Merged
dewabisma merged 3 commits into
beast/add-infinite-scroll-and-pull-to-refreshfrom
beast/some-fixes
May 27, 2026
Merged

Some fixes#500
dewabisma merged 3 commits into
beast/add-infinite-scroll-and-pull-to-refreshfrom
beast/some-fixes

Conversation

@dewabisma

@dewabisma dewabisma commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Small UI/validation tweaks on account screens and removal of a non-functional mining button; no auth, payments, or persistence logic changes.

Overview
Tightens account name flows and hides unfinished mining redeem UI.

Create account drops inline _error on NameField and no longer disables the primary action because of that state. The create button stays disabled only when the trimmed name is empty or a create is in progress.

Edit account now disables Done when the trimmed name is empty, matching create behavior and avoiding a no-op save tap (empty names still show a toaster in _save if reached).

Mining rewards removes the bottom Redeem bar (it had onTap: null) and comments it with a TODO until redeem is implemented; related button/scaffold imports are removed.

Reviewed by Cursor Bugbot for commit f3d243b. Bugbot is set up for automated code reviews on this repo. Configure here.

@dewabisma dewabisma requested a review from n13 May 25, 2026 10:50
@dewabisma dewabisma merged commit 4e21cd4 into beast/add-infinite-scroll-and-pull-to-refresh May 27, 2026
2 checks passed
@dewabisma dewabisma deleted the beast/some-fixes branch May 27, 2026 05:35
dewabisma added a commit that referenced this pull request May 27, 2026
* feat: setup l10n and implement to auth wrapper

* feat: localize wallet init screen

* feat: onboarding flow localized

* feat: localize home and activity

* feat: localize manage account flow

* feat: localized send flow

* feat: localize activity related screen and widgets

* feat: localize receive and pos screens

* feat: localize setting screens

* feat: localized swap screens

* feat: localized shared components

* feat: finish integrating language localization

* feat: address review issues

- refactor DRY widget
- delete redundant provider
- fix bad number formatting locale

* feat: another review fixes

* chore: formatting

* fix: lint error

- use intl from sdk
- import legacy provider

* feat: address reset bug

* feat: remove redundant setting clear

Setting already cleared in substarte service logout

* fix: reset depend on setting clear

* chore: sync lock file

* fix: resolve review issues

* feat: update activity screen

- implement infinite scroll
- implement pull to refresh

* chore: formatting

* chore: excluce build folder content from flutter analyze

* fix: scroll interefering each filter state

* fix: race fetch pull and scroll

* feat: properly debug sensitive information

* fix: not waiting settings clean up

* feat: resolve PR issues

* feat: make error logged, refactor repeating pagination data access into getter

* fix: can't remove error in pagination state

* feat: make better empty view in activity screen

* fix: PR issues

* feat: make error clear explicit

* feat: remove tx filters

* chore: formatting

* feat: handle race fetch condition

* fix: silent refersh bug

* fix: stuck loading

* fix: properly show loader

* chore: formatting

* fix: fetch more not showing loading

* fix: stuck loading on failed getting account

* remove dead code cleanup

* Some fixes (#500)

* fix: prevent from creating account name using whitespace only

* feat: remove redeem button

---------

Co-authored-by: Nikolaus Heger <nheger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant