Skip to content

check for missing mnemonic#435

Merged
n13 merged 4 commits into
mainfrom
check_for_missing_mnemonic
Apr 3, 2026
Merged

check for missing mnemonic#435
n13 merged 4 commits into
mainfrom
check_for_missing_mnemonic

Conversation

@n13

@n13 n13 commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Fix for #434

  • On startup, check for mnemonic!
  • If missing, log user out
  • Setting to store mnemonic in encrypted backups (iOS)

Mnemonic still won't get stored in unencrypted backups, that's an iOS safety feature.

Testing

Change the code to always pretend like the mnemonic is missing, ie
instead of
if (mnemonic == null) {
do

  if (true) {

Comment thread mobile-app/flutter_launcher_icons.yaml

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, just not sure that the change path about in launcher.yaml

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n13 n13 merged commit 17a1bf5 into main Apr 3, 2026
1 check passed
@dewabisma dewabisma deleted the check_for_missing_mnemonic branch May 3, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants