scan deep link QR from send page#430
Merged
Merged
Conversation
dewabisma
reviewed
Mar 31, 2026
| if (payment != null) { | ||
| _recipientController.text = payment.to; | ||
| _amountController.text = payment.amount; | ||
| } else { |
Collaborator
There was a problem hiding this comment.
Why we set text as result? Seems at this point result is malformed
Collaborator
Author
There was a problem hiding this comment.
In this case it's a plain QR code
we validate the input now so we either get a valid payment link or a valid QUAN address as a result from the scanner - the scanner returns null for anything that's not one of these things.
Collaborator
Author
There was a problem hiding this comment.
Good question though, I had to go through the code
Collaborator
There was a problem hiding this comment.
Ohh I see, okay looks good!
dewabisma
reviewed
Mar 31, 2026
dewabisma
left a comment
dewabisma
left a comment
Collaborator
There was a problem hiding this comment.
Overall looking good, one thing to confirm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #429