Skip to content

android edge to edge fix#406

Merged
n13 merged 3 commits into
mainfrom
fix_android_settings
Feb 27, 2026
Merged

android edge to edge fix#406
n13 merged 3 commits into
mainfrom
fix_android_settings

Conversation

@n13

@n13 n13 commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

This PR fixes Android edge-to-edge and lint issues for release builds.
It removes deprecated Flutter system bar color calls, keeps edge-to-edge enabled, and updates Android theme/resource config to satisfy lintRelease without changing cross-platform build portability.

Included changes

  • Removed explicit SystemUiOverlayStyle status/navigation bar color settings in mobile-app/lib/main.dart.
  • Added optional camera hardware declaration (required=false) in mobile-app/android/app/src/main/AndroidManifest.xml to resolve ChromeOS-related lint error.
  • Updated launch themes in:
    • mobile-app/android/app/src/main/res/values/styles.xml
    • mobile-app/android/app/src/main/res/values-night/styles.xml
      using tools:targetApi on API-gated attributes (forceDarkAllowed, windowLayoutInDisplayCutoutMode) so behavior is preserved and lint passes.
  • Removed machine-specific Gradle JDK pin from mobile-app/android/gradle.properties to avoid environment-specific breakage.

Verification

  • :app:lintRelease passes when run with JDK 21.

@n13

n13 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator Author

the build works on Android, I don't know if it will get rid of the warnings...

@n13 n13 marked this pull request as ready for review February 27, 2026 04:20

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine if it works. But a little disturbed by the different targetApi. We defined 27 and 29. Shouldn’t we stick to one?

@n13

n13 commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator Author

These settings apply to different targets - AI thinks this will kill the warnings. but we will only see this once we upload. If this doesn't work I will manually fix it ;)

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, let's do this!

@n13 n13 merged commit e28cb57 into main Feb 27, 2026
1 check passed
@dewabisma dewabisma deleted the fix_android_settings branch May 3, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants