Skip to content

Remove init quest promo#350

Merged
dewabisma merged 6 commits into
mainfrom
feat/remove-init-quest-promo
Jan 7, 2026
Merged

Remove init quest promo#350
dewabisma merged 6 commits into
mainfrom
feat/remove-init-quest-promo

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

Key Changes

1. Refactoring ReferralActionSheet

  • Renaming: ReferralAndRewardActionSheet has been appropriately renamed to ReferralActionSheet, reflecting that it now focuses solely on the referral code entry and submission.
  • Cleanup:
    • Removed QuestsPromoVideo import and usage.
    • Removed directlyShowRewardProgram, showRewardProgram, and related state variables (_isRewardProgram, _isLastPromo).
    • Removed the _handleOptIn and _handleSkipReferral logic, which significantly simplifies the component.
  • Logic: The _buildSheetContent method is now much cleaner, handling only the loading state, submission success (checksum), or the input form.

2. Quests Tab & Opt-In Flow (QuestsScreen & Navbar)

  • Deferred Loading: The QuestsScreen now accepts a playPromoVideo boolean.
  • Navbar Integration: In Navbar.dart, playPromoVideo is derived from _selectedIndex == 3. This is a good optimization for IndexedStack. It ensures that the heavy video content or the "Opt-In" flow in QuestsScreen only initializes/plays when the user actually navigates to that tab.
  • Behavior:
    • When the tab is inactive (playPromoVideo is false), QuestsScreen shows a lightweight loading placeholder.
    • When active, if the user hasn't opted in (!_isRewardProgramParticipant), it effectively replaces the removed referral sheet promo by showing the QuestsPromoVideo directly on the screen.

3. Minor UI Adjustments

  • Reset Confirmation: reset_confirmation_bottom_sheet.dart saw some structural formatting changes (removing an outer Padding widget). This likely tightens the layout of the bottom sheet.
  • Settings Screen: Updated to use the new showReferralFormActionSheet function.

@dewabisma dewabisma requested a review from n13 January 6, 2026 13:31
@n13

n13 commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Why did the skip button disappear?

Simulator Screenshot - iPhone 17 - 2026-01-07 at 14 51 50

@n13 n13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add referral skip button back in

@dewabisma

Copy link
Copy Markdown
Collaborator Author

please add referral skip button back in

Okay, added back.

image

@dewabisma dewabisma requested a review from n13 January 7, 2026 07:06
@n13

n13 commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Having a lot of problems creating new account

There's a lot of "loading" screens that take forever - also they don't need to be there.

The referral page doesn't need to load referral status when we just created a wallet - referral is not set yet.

flutter: getReferralData response: {"error":"An internal server error occurred"}
flutter: Error fetching miner stats: Exception: Reward Program http request failed with status: 500. Body: {"error":"An internal server error occurred"}
flutter: #0 TaskmasterService.getRewardProgramParticipation (package:quantus_sdk/src/services/taskmaster_service.dart:447:9)
taskmaster_service.dart:447

#1 ReferralService.getRewardProgramParticiation (package:resonance_network_wallet/services/referral_service.dart:118:24)
referral_service.dart:118

flutter: Error fetching miner stats: Exception: Reward Program http request failed with status: 500. Body: {"error":"An internal server error occurred"}
flutter: #0 TaskmasterService.getRewardProgramParticipation (package:quantus_sdk/src/services/taskmaster_service.dart:447:9)
taskmaster_service.dart:447

#1 ReferralService.getRewardProgramParticiation (package:resonance_network_wallet/services/referral_service.dart:118:24)
referral_service.dart:118

#2 _QuestsScreenState._loadParticipationStatus (package:resonance_network_wallet/features/main/screens/quests/quests_screen.dart:43:29)
quests_screen.dart:43

flutter: getReferralData response: {"error":"An internal server error occurred"}

Create account does not need network calls

@n13 n13 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG now

@n13

n13 commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

Having a lot of problems creating new account

There's a lot of "loading" screens that take forever - also they don't need to be there.

The referral page doesn't need to load referral status when we just created a wallet - referral is not set yet.

flutter: getReferralData response: {"error":"An internal server error occurred"} flutter: Error fetching miner stats: Exception: Reward Program http request failed with status: 500. Body: {"error":"An internal server error occurred"} flutter: #0 TaskmasterService.getRewardProgramParticipation (package:quantus_sdk/src/services/taskmaster_service.dart:447:9) taskmaster_service.dart:447 #1 ReferralService.getRewardProgramParticiation (package:resonance_network_wallet/services/referral_service.dart:118:24) referral_service.dart:118 flutter: Error fetching miner stats: Exception: Reward Program http request failed with status: 500. Body: {"error":"An internal server error occurred"} flutter: #0 TaskmasterService.getRewardProgramParticipation (package:quantus_sdk/src/services/taskmaster_service.dart:447:9) taskmaster_service.dart:447 #1 ReferralService.getRewardProgramParticiation (package:resonance_network_wallet/services/referral_service.dart:118:24) referral_service.dart:118 #2 _QuestsScreenState._loadParticipationStatus (package:resonance_network_wallet/features/main/screens/quests/quests_screen.dart:43:29) quests_screen.dart:43 flutter: getReferralData response: {"error":"An internal server error occurred"}

All this happened because task master was down, but it showed us some things we can improve, like removing waits from create account

@dewabisma dewabisma merged commit 7e4899b into main Jan 7, 2026
1 check passed
@dewabisma dewabisma deleted the feat/remove-init-quest-promo branch January 7, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants