feat: add "deploy and apply immediately" action for managed databases#2570
feat: add "deploy and apply immediately" action for managed databases#2570
Conversation
|
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2570 +/- ##
===========================================
- Coverage 47.66% 47.24% -0.43%
===========================================
Files 1280 1243 -37
Lines 23766 23497 -269
Branches 7020 7007 -13
===========================================
- Hits 11327 11100 -227
+ Misses 10285 10274 -11
+ Partials 2154 2123 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 |
There was a problem hiding this comment.
Pull request overview
Adds a “Deploy database” modal for managed databases so users can choose between deploying at the next maintenance window (default) or applying immediately.
Changes:
- Introduces a new
DatabaseDeployModalcomponent anduseDatabaseDeployModalhelper hook. - Hooks the modal into the service action toolbar deploy action and the “Need redeploy” banner flow for managed databases.
- Extends the services deploy mutation to support an
applyImmediatelyflag for database deployments.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/domains/services/feature/src/lib/service-action-toolbar/service-action-toolbar.tsx | Opens the new modal for managed DB deploys and forwards applyImmediately. |
| libs/domains/services/feature/src/lib/need-redeploy-flag/need-redeploy-flag.tsx | Opens the new modal from the redeploy banner for managed DBs and forwards applyImmediately. |
| libs/domains/services/feature/src/lib/database-deploy-modal/use-database-deploy-modal/use-database-deploy-modal.tsx | Adds a hook to open the DB deploy modal via the shared modal system. |
| libs/domains/services/feature/src/lib/database-deploy-modal/database-deploy-modal.tsx | Implements the modal UI for selecting deploy timing. |
| libs/domains/services/data-access/src/lib/domains-services-data-access.ts | Adds applyImmediately to the DB deploy request and binds it to the API call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/domains/services/feature/src/lib/service-action-toolbar/service-action-toolbar.tsx
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/need-redeploy-flag/need-redeploy-flag.tsx
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/database-deploy-modal/database-deploy-modal.tsx
Outdated
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/database-deploy-modal/database-deploy-modal.tsx
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/database-deploy-modal/database-deploy-modal.tsx
Outdated
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/service-action-toolbar/service-action-toolbar.tsx
Outdated
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/need-redeploy-flag/need-redeploy-flag.tsx
Outdated
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/service-action-toolbar/service-action-toolbar.tsx
Outdated
Show resolved
Hide resolved
libs/domains/services/feature/src/lib/need-redeploy-flag/need-redeploy-flag.tsx
Outdated
Show resolved
Hide resolved
|
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 |
Summary
Issue: QOV-1553
PR adding a new modal when clicking the "deploy" action for managed databases.
It will allow users to choose whether they want to deploy their changes during the next maintenance window (default), or immediately.
Slacks threads for reference:
Screenshots / Recordings
📺 https://www.loom.com/share/53b03890730649c1a15ad0cf72d2fb16
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release