Skip to content

feat: add "deploy and apply immediately" action for managed databases#2570

Open
rmnbrd wants to merge 5 commits intostagingfrom
feat/databases/redeploy-immediately-QOV-1553
Open

feat: add "deploy and apply immediately" action for managed databases#2570
rmnbrd wants to merge 5 commits intostagingfrom
feat/databases/redeploy-immediately-QOV-1553

Conversation

@rmnbrd
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd commented Apr 2, 2026

Summary

Issue: QOV-1553

PR adding a new modal when clicking the "deploy" action for managed databases.
It will allow users to choose whether they want to deploy their changes during the next maintenance window (default), or immediately.

Slacks threads for reference:

Screenshots / Recordings

📺 https://www.loom.com/share/53b03890730649c1a15ad0cf72d2fb16

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Copy Markdown
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview d8a1b661-72ac-4c66-97c9-89bc61392356 test-prod-clone-prod
/qovery preview 8ba67a97-56f5-4655-9090-f29ba94c581f test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.24%. Comparing base (437fd05) to head (1763295).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...ib/database-deploy-modal/database-deploy-modal.tsx 0.00% 18 Missing ⚠️
.../service-action-toolbar/service-action-toolbar.tsx 20.00% 12 Missing ⚠️
.../src/lib/need-redeploy-flag/need-redeploy-flag.tsx 37.50% 9 Missing and 1 partial ⚠️
...atabase-deploy-modal/use-database-deploy-modal.tsx 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2570      +/-   ##
===========================================
- Coverage    47.66%   47.24%   -0.43%     
===========================================
  Files         1280     1243      -37     
  Lines        23766    23497     -269     
  Branches      7020     7007      -13     
===========================================
- Hits         11327    11100     -227     
+ Misses       10285    10274      -11     
+ Partials      2154     2123      -31     
Flag Coverage Δ
unittests 47.24% <23.63%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd self-assigned this Apr 2, 2026
@rmnbrd rmnbrd requested a review from RemiBonnet April 2, 2026 17:24
@rmnbrd rmnbrd marked this pull request as ready for review April 2, 2026 17:24
Copilot AI review requested due to automatic review settings April 2, 2026 17:24
@rmnbrd
Copy link
Copy Markdown
Contributor Author

rmnbrd commented Apr 2, 2026

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “Deploy database” modal for managed databases so users can choose between deploying at the next maintenance window (default) or applying immediately.

Changes:

  • Introduces a new DatabaseDeployModal component and useDatabaseDeployModal helper hook.
  • Hooks the modal into the service action toolbar deploy action and the “Need redeploy” banner flow for managed databases.
  • Extends the services deploy mutation to support an applyImmediately flag for database deployments.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
libs/domains/services/feature/src/lib/service-action-toolbar/service-action-toolbar.tsx Opens the new modal for managed DB deploys and forwards applyImmediately.
libs/domains/services/feature/src/lib/need-redeploy-flag/need-redeploy-flag.tsx Opens the new modal from the redeploy banner for managed DBs and forwards applyImmediately.
libs/domains/services/feature/src/lib/database-deploy-modal/use-database-deploy-modal/use-database-deploy-modal.tsx Adds a hook to open the DB deploy modal via the shared modal system.
libs/domains/services/feature/src/lib/database-deploy-modal/database-deploy-modal.tsx Implements the modal UI for selecting deploy timing.
libs/domains/services/data-access/src/lib/domains-services-data-access.ts Adds applyImmediately to the DB deploy request and binds it to the API call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rmnbrd
Copy link
Copy Markdown
Contributor Author

rmnbrd commented Apr 2, 2026

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants