Skip to content

feat(helm): add creation flow#2552

Merged
RemiBonnet merged 17 commits intonew-navigationfrom
feat/new-nav/helm-creation-flow
Apr 3, 2026
Merged

feat(helm): add creation flow#2552
RemiBonnet merged 17 commits intonew-navigationfrom
feat/new-nav/helm-creation-flow

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

@RemiBonnet RemiBonnet commented Mar 27, 2026

Summary

  • Add HELM creation flow

Screenshots / Recordings

https://www.loom.com/share/7f285613faab4920ae02462090e8a1bc

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet RemiBonnet added the V5 label Mar 27, 2026
@RemiBonnet
Copy link
Copy Markdown
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

The backlog never ends, be at peace with it

Comment thread libs/shared/ui/src/lib/components/icon/icons-status/skip.tsx
@RemiBonnet RemiBonnet marked this pull request as ready for review March 30, 2026 11:59
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@3303d7c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...eral-settings/service-general-settings-payloads.ts 0.00% 6 Missing ⚠️
...d/ui/src/lib/components/icon/icons-status/skip.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2552   +/-   ##
=================================================
  Coverage                  ?   44.61%           
=================================================
  Files                     ?     1055           
  Lines                     ?    21575           
  Branches                  ?     6326           
=================================================
  Hits                      ?     9626           
  Misses                    ?    10226           
  Partials                  ?     1723           
Flag Coverage Δ
unittests 44.61% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


const handleSubmit = valuesOverrideArgumentsForm.handleSubmit((data) => {
valuesOverrideArgumentsForm.reset(data)
navigate({ to: `${creationFlowUrl}/summary`, search })
Copy link
Copy Markdown
Contributor

@rmnbrd rmnbrd Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the navigation is handled in this function, whereas it is also handled in a different manner there:

Image

Could we have something coherent?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 74e7596

@RemiBonnet RemiBonnet merged commit c44fcab into new-navigation Apr 3, 2026
11 checks passed
@RemiBonnet RemiBonnet deleted the feat/new-nav/helm-creation-flow branch April 3, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants