Semicolon/Hashtag chars in values should not start comments

[mixmastamyk]

Using configparser = "3.1.0"

I have a Python tool that I ported to Rust.

I'm using semicolons (shell commands) in the values in my config.ini. That works in Python, but not in your Rust library.

The reason it seems is that Python ConfigParser only recognizes comment chars when they start a line. In a value, they are part of the value. e.g.:

# cat config.ini
[section]
; This is a comment, but not below:
foo = bar; baz

Python CP output:

section: {'foo': 'bar; baz' ...}

Rust CP output:

section: {"foo": Some("bar") ...}

Please match the Python CP way of handling comments. My Rust port is somewhat broken until this can be fixed. Thank you.

[mixmastamyk]

Looks like this block is the problem:

https://github.com/QEDK/configparser-rs/blob/master/src/ini.rs#L837

[QEDK]

Using configparser = "3.1.0"

I have a Python tool that I ported to Rust.

I'm using semicolons (shell commands) in the values in my config.ini. That works in Python, but not in your Rust library.

The reason it seems is that Python ConfigParser only recognizes comment chars when they start a line. In a value, they are part of the value. e.g.:

cat config.ini

[section]
; This is a comment, but not below:
foo = bar; baz
Python CP output:

section: {'foo': 'bar; baz' ...}

Rust CP output:

section: {"foo": Some("bar") ...}

Please match the Python CP way of handling comments. My Rust port is somewhat broken until this can be fixed. Thank you.

This would break current behaviour so highly unlikely to patch this in. But you can customize comment symbols, so if you want to use semi-colons as values, I would suggest simply making an IniDefault with a different comment symbols list without a semi-colon.

[mixmastamyk]

Ok, however this seems to be a bug in following the spec. Which ideally should be handled somehow, even if it can't practically be made default. Perhaps with another option field in the defaults struct? enable_inline_comments or similar?

Btw, I made the change slightly differently than the IniDefault example:

use configparser::ini::{Ini, IniDefault};

let mut parser_options = IniDefault::default();
parser_options.comment_symbols = vec!['#'];
let mut config = Ini::new_from_defaults(parser_options);

I think this might create one less Ini struct than the example. Also I noticed the IniDefault.boolean_values field has no documentation lines.

[QEDK]

Ok, however this seems to be a bug in following the spec. Which ideally should be handled somehow, even if it can't practically be made default. Perhaps with another option field in the defaults struct? enable_inline_comments or similar?

Btw, I made the change slightly differently than the IniDefault example:

use configparser::ini::{Ini, IniDefault};

let mut parser_options = IniDefault::default();
parser_options.comment_symbols = vec!['#'];
let mut config = Ini::new_from_defaults(parser_options);
I think this might create one less Ini struct than the example. Also I noticed the IniDefault.boolean_values field has no documentation lines.

This crate is only inspired from the Python library, not intended to be a 1-to-1 representation. Am I correct in understanding this works for you? Then, we can simply make it a feature request and will be happy to take in contributions that support this.

[mixmastamyk]

Yes, the code above worked.

[mixmastamyk]

Thanks. Would be helpful to know which version the associated code will land in.