Merged
Conversation
…o create_dedicated_us_inputs
Contributor
Author
|
Hi @lkstrp, thanks for your support :) I believe that once this PR is merged, we will need a new (minor) release. Thanks :) Fabrizio |
5 tasks
5 tasks
…o create_dedicated_us_inputs
fneum
approved these changes
Feb 18, 2025
Member
fneum
left a comment
There was a problem hiding this comment.
Good to go!
At some point we need to discuss:
- moving data inputs out of the repository into a zenodo or alternative data store
- moving the outputs out of the repository into a zenodo (with an automated release pipeline for US and EU specific data
- structurally, it would be nicer to have a config that toggles between EU/US/global rather than two separate rules for compiling the data.
But these points are not directly relevant for this PR.
| nrel_atb_input_discount_rate="inputs/discount_rates_usa.csv", | ||
| nrel_atb_input_fuel_costs="inputs/fuel_costs_usa.csv", | ||
| nrel_atb_manual_input_usa="inputs/US/manual_input_usa.csv", | ||
| eur_inflation_rate="inputs/prc_hicp_aind__custom_9928419_spreadsheet.xlsx", |
Member
There was a problem hiding this comment.
Not directly relevant for this PR, but these inflation rates are for Europe and should probably be substituted by a US-specific dataset.
Contributor
Author
There was a problem hiding this comment.
Hi @fneum,
I agree and we should find it ASAP on the dedicated US website before the information gets deleted.
I will raise (yet) another PR.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR addresses some of the concerns expressed by @fneum in the comment to the pull-request.
The PR proposes the following changes. Namely, it
Tests
The output files generated by scripts/compile_cost_assumptions.py are compared to the ones available at commit (the commit is the one that pre-dates the merge of the pull-request). The comparison is available in the attached file comparison.txt
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.