Repository navigation
Fix php-cfg-new-first-class-callable patch on clean install (#9931) - #9934
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php-cfg-new-first-class-callable.patchthrough an anchor-based overlay inapply-patches.shsoKIND_NEW/new C(...)FCC lowering survives Parser.php drift from prior overlays.php-cfg-anonymous-class.patchbefore the new-FCC overlay (the overlay expectsparseExpr_Newwith anonymous-class handling).patch_already_appliedmarker forKIND_NEW.Root cause
On a clean
composer install,php-cfg-first-class-callable.patchapplied butphp-cfg-new-first-class-callable.patchfailed atParser.php:1625because it assumed anonymous-class + stale line anchors.apply-patches.shexited 1 andrelease-readiness.shdied inci_install_deps.Verification
Closes #9931
Made with Cursor