Fix duplicate backed enum values at compile time (#9677) - #9916
Merged
Merged
Conversation
Reject literal duplicate int/string backing values in EnumBackedCaseCheck
so scripts like enum E { case A=1; case B=1; } fail before runtime.
Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnumBackedCaseCheck::validate()to reject backed enum declarations whose case initializers are compile-time duplicate int/string scalars.php-src reference
Zend/zend_enum.c—zend_register_enum_caseduplicate backing detectionPHP implementation
lib/Compiler/EnumBackedCaseCheck.php— compile-time duplicate backing scanVerification
Closes #9677
Made with Cursor