Repository navigation
Fix property set hook throw must abort assignment (#9670) - #9709
Merged
Merged
Conversation
Route set-hook throws and catchable hook-body errors through the same external-catch bubble used by get/unset hooks so try blocks do not resume after catch. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throwthroughpropertyHookExternalCatchFrame+FAILURE, matching the get/unset hook unwinding fix from Language: property hook unset — exception from hook must abort unset and propagate (Zend/zend_property_hooks.c) #9666Error,dispatchVmError/dispatchVmTypeError) out of isolated hook stacks viastashPropertyHookSetExternalCatchso outertryblocks do not resume aftercatchlib/VM.phponly — no C runtime changesphp-src reference:
Zend/zend_property_hooks.c,Zend/zend_execute.cVerification
Closes #9670
Made with Cursor