Fix is_callable() third $callable_name by-ref argument (#9505) - #9509
Merged
Conversation
Register the optional name out-param in BuiltinByRefParams, write through resolveIndirect() in VmCallable (replacing the broken isReference() call), align php-src name population on failure paths, and teach JitIsCallable to write the resolved name under AOT. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_callableargument Stdlib: ceil, floor, intval and expanded PHPT specs #3 ($callable_name) inBuiltinByRefParams/BuiltinParamNamesso the VM validates and binds by-ref correctly.VmCallable::writeCallableName()— useresolveIndirect()->string()(the oldVariable::isReference()call was undefined and fatal).$callable_nameeven when the check returns false (e.g. unknown function still reports'NoSuchFunction_xyz').JitIsCallableto write the resolved name into the third argument under AOT/JIT.php-src reference:
ext/standard/basic_functions.c—PHP_FUNCTION(is_callable)Verification
Closes #9505
Made with Cursor