Repository navigation
Fix 005/006 examples web smoke: docblock broke superglobal dim fetch (#9226) - #9314
Merged
Merged
Conversation
Long docblocks in 005/006 example.php broke $_POST/$_FILES dim fetches inside POST branches (compiler #1887 class bug). Use short comments, null-coalesce for flash, and guard regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message=Savedexamples) with a short comment and use$_POST['message'] ?? 'saved'so POST flash persists in session acrossphpc serverequests.$_FILES['doc']is visible on multipart POST.TernaryArrayDimFetchMergeTest::test005SessionsWebExamplePostPersistsFlashguard.Root cause: the shipped docblocks triggered a compile-time bug (#1887 class) where
$_POST['message']/$_FILES['doc']resolved empty inside POST branches despite populated superglobals — session file showedflash;Nand uploads showed “No upload yet”.php-src reference: N/A (web integration / compiler). Zend behavior unchanged; examples now match expected serve smoke.
Closes #9226
Verification
Made with Cursor