Skip to content

Close #9127: expand magic_const_filestat compliance after #9139 - #9146

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-9127-magic-const-filestat-close
Jun 17, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-9127-magic-const-filestat-close

Conversation

@PurHur

@PurHur PurHur commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

php-src reference: Zend/zend_compile.c magic constants + ext/standard/filestat.c — compile fix in PHP (lib/Compiler.php); stat builtins unchanged.

Closes #9127

Verification

source script/php-env.sh
php test/repro/maintainer_magic_const_filestat.php
# true / true

php bin/vm.php test/repro/maintainer_magic_const_filestat.php
# true / true

./script/docker-exec.sh -- bash -lc './vendor/bin/phpunit --filter magic_const_filestat'
# OK (2 tests, 2 assertions) — VM + JIT

Made with Cursor

Root fix landed in #9139 (#9136); widen VM/JIT phpt to cover inline
__DIR__/__FILE__ on is_dir/is_file/stat builtins per issue done-when.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit 6f30cb7 into master Jun 17, 2026
@PurHur
PurHur deleted the agent/issue-9127-magic-const-filestat-close branch June 17, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: file_exists()/is_dir()/is_file() with inline __DIR__/__FILE__ return false (magic constant lowering)

1 participant