Repository navigation
Language: static property union types (string|int) — VM parity (#8726) - #8740
Merged
Merged
Conversation
…it (#8726) Wire union/DNF metadata for static typed properties on VM and JIT declare paths, fix boxed scalar default init for TYPE_VALUE static slots, and add compliance coverage. MCJIT execute for scalar union static props remains gated in JITTest until MCJIT static fetch is stable. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public static string|int $pbut JIT boxed (TYPE_VALUE) static slots with scalar defaults were never initialized, and DNF metadata was not wired for static property declare/fetch/assign.scriptHasDnfTypedProperties).JITTest(segfault on declare/fetch — same class of issue as#4908).php-src reference
Zend/zend_compile.c— static property type compilation (PHP 8.4)lib/Compiler.php(compileTypeConstrainedVariable,TYPE_DECLARE_STATIC_PROPERTY),lib/VM.php(unionTypeConstraintson assign),lib/JIT/Builtin/Type/Object_.phpVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/static_property_union_type.php'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter static_property_union_type'Closes #8726
Made with Cursor