Fix AOT isset on typed array property copied to local (#848) - #873
Merged
Merged
Conversation
Initialize hashtable locals to null before assignOperand free(), detach object property slots in dimFetch like isset, and load typed array properties directly in IssetHelper. Makes isset_object_property_array.phpt execute green. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__hashtable__*locals to null so firstassignOperanddoes notdelrefgarbage (Testing: isset_object_property_array.phpt AOT execute green (resolveAppName, #764) #848).objectPropertySlotindimFetchthe same wayisset()already does (AOT: MiniWebApp native binary CLI execute emits empty stdout (post-link) #764).arrayobject properties directly inIssetHelperinstead of__object__load_value_slot.Test plan
vendor/bin/phpunit --filter isset_object_property_array(AOT link + execute)vendor/bin/phpunit test/aot/AotTest.php(182 tests)vendor/bin/phpunit test/unit/ObjectPropertyArrayAotCompileTest.phpVerified in Docker (
php-compiler:22.04-dev).Closes #848.
Made with Cursor