Repository navigation
Fix constant() enum case identity for class consts (#5682) - #8627
Merged
Merged
Conversation
…#5682). Canonicalize enum singletons on constant()/class-const fetch and compare enum cases by FQCN + case name so compile-time stubs match runtime entries. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constant('C::X')whenC::X = E::Anow returns the canonical enum case singleton viaEnumCaseSupport::materializeConstantValue()on class-const lookup (VmConstants,VM::copyClassConstOrStaticPropertyByName).===between enum cases compares declaring enum FQCN + case name instead ofClassEntryobject identity, fixing mismatches between compile-time stub entries and runtime enum classes (declare(strict_types=1)repro).php-src reference:
ext/standard/basic_functions.c(zif_constant),Zend/zend_enum.c(case singleton identity)PHP implementation:
ext/standard/VmConstants.php,lib/VM.php,lib/VM/EnumCaseSupport.php— noruntime/C changes.Closes #5682
Verification
Output:
Made with Cursor