Repository navigation
Fix hash crypto LLVM IR validation for bootstrap-aot-link (#7189) - #8500
Merged
Merged
Conversation
Correct StringHashCryptoNativeJit helper signatures (sha256/sha1 transform i32* state), zExt/trunc casts, HKDF infoData dominance, HMAC/PBKDF2 i8 stores, and emitCompilerHashHmac bad-algo path — unblocks AOT compile of hash()/hash_hmac() call sites that previously failed module verify. Co-authored-by: Cursor <cursoragent@cursor.com>
16 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lane B bootstrap fallback — no eligible compile/link issue in lane (
# % 3 == 1without stdlib/php-runtime ownership; 1000 open issues scanned).make bootstrap-aot-linkwas red: hash()/hash_hmac() AOT compile failed LLVM module verify inStringHashCryptoNativeJit(#7189 / #7437).Fixes in
lib/JIT/Builtin/StringHashCryptoNativeJit.php:__phpc_hc_sha256_transform/__phpc_hc_sha1_transformexternal decls with emitters (i32*state, noti8*)u32()useszExtOrBitCast(wastruncOrBitCaston i8 md5 block loads)infoData/infoLenin body block; init loop slots afterpositionAtEnd($loopHead)(dominance)emitCompilerHashHmacbad-algo path: ValueError +sealOpenBlock(parity withemitCompilerHash)zExtOrBitCastthroughout digest update loopsVerification
Follow-up: AOT runtime digest for
hash("md5", …)still returns wrong bytes + segfault onhash_hmacin native binary (VM/JIT OK).make bootstrap-aot-linkcompile phase unblocked; full gate still red on unrelated targets + AOT digest runtime.Relates to #7189, #7437, #1492.
Made with Cursor