Stdlib: mb_substr/mb_strpos/mb_strtolower/mb_strtoupper UTF-8 VM (#3239) - #8440
Merged
Merged
Conversation
Register core mbstring helpers in ext/mbstring using VmMbstring/VmString UTF-8 codepoint paths (php-src ext/mbstring/mbstring.c). Closes gap where only mb_strlen existed for multibyte string manipulation. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mb_substr(),mb_strpos(),mb_strtolower(), andmb_strtoupper()inext/mbstring/(php-srcext/mbstring/mbstring.c).VmMbstring+VmString::utf8CharSubstr()— no new C runtime.Closes #3239
php-src reference
ext/mbstring/mbstring.c—php_mb_substr,php_mb_strpos, case conversion wrappersPHP implementation
ext/mbstring/mb_substr.php,mb_strpos.php,mb_strtolower.php,mb_strtoupper.phpext/mbstring/VmMbstring.php—substr(),strpos(),strtolower(),strtoupper()Verification
Issue repro:
Output:
Repro script + compliance:
Output:
Made with Cursor