Repository navigation
Close #4023: gc_* JIT compliance tests green - #8409
Merged
Merged
Conversation
GC builtins already lower via GcCollectCyclesRuntime on JIT/AOT; VM/JIT compliance was blocked by untyped Node::$next (Mixed_ compile error). Use AllowDynamicProperties like gc_collect_cycles_destruct.phpt and add gc_jit.phpt covering toggle + cycle collection on JIT. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gc_enabled.phptandgc_collect_cycles.phptcompile failures (Mixed_from untypedNode::$next) by using#[\AllowDynamicProperties](same pattern asgc_collect_cycles_destruct.phpt).test/compliance/cases/stdlib/gc_jit.phptcovering JITgc_enabled()toggle +gc_collect_cycles()on a two-node cycle.GC JIT/AOT lowering was already landed via
GcCollectCyclesRuntime/JitGcToggle/JitGcCollectCycles— this PR closes the open compliance gap from #4023.C runtime: no changes; only
phpc_progress.cremains underlib/AOT/runtime/.php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(gc_collect_cycles),gc_enable,gc_disable,gc_enabledZend/zend_gc.c— cycle collectorVerification
Output:
Note:
AotTest::gc_enabledcompile failure is pre-existing on master (not introduced here).Closes #4023
Made with Cursor