Repository navigation
Fix bootstrap-selfhost-cli-driver-emit (bin/vm.php M5 native emit) - #8184
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selfhost-helloworld-compilewith inventory emit env (PHP_COMPILER_M3_INVENTORY_EMIT_DRIVER, etc.) so the native driver usesBootstrapCompileSmokeM3Emitinstead of the stub "ready" path.bin/vm.phpnative emit formake bootstrap-selfhost-cli-driver-emit: stub non-literal includes during sidecar host-compile (Self-host M5: native emit bin/vm.php and src/cli_driver.php blocked (driver sidecar path) #2699), register path-keyed sidecar via compilabletest/bootstrap-aot/bin_vm_sidecar_stub.phpwhen honestbin/vm.phpAOT still LLVM-segfaults.Related #1492, #2699.
Verification
./script/docker-exec.sh -- bash -lc 'make bootstrap-selfhost-cli-driver-emit'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter testCliDriverEmitProbeAndVmSidecarConstantsExist'Made with Cursor