Repository navigation
Stdlib: JIT/AOT date_sunrise()/date_sunset() (#6137) - #8125
Merged
Merged
Conversation
Compile-time literal baking via JitDateSunFunc mirrors date_sun_info; preserve compileTimeFloat through unary-minus and temporary boxing for negative coords. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JitDateSunFunccompile-time literal baking fordate_sunrise()/date_sunset()(php-srcext/date/php_date.c, sharedVmDateSunNativeastro core php-in-php: VmDateSunNative — date_sunrise/sunset/info without host Zend delegation (ext/date/lib/astro.c) #8003).date_sunrise/date_sunsetInternal::call()to the new lowerer (mirrorsJitDateSunInfofordate_sun_info()).compileTimeFloatthrough unary-on float literals and temporary__value__boxing so negative longitudes (e.g. London-0.1) bake correctly in AOT.php-src reference
ext/date/php_date.c—PHP_FUNCTION(date_sunrise),PHP_FUNCTION(date_sunset)ext/date/lib/astro.c— ported inext/standard/VmDateSunNative.phpVerification
Closes #6137
Made with Cursor