Repository navigation
Stdlib: array_udiff/uintersect enum case callbacks (#5637) - #8103
Merged
Merged
Conversation
User-comparator array set ops must not apply rejectEnumCaseSetOpOperands; Zend passes enum case objects to compare callbacks. Add compliance PHPT and maintainer repro for VM/JIT parity. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rejectEnumCaseSetOpOperandsguard fromVmArrayUserSetOps— user-comparatorarray_udiff*/array_uintersect*/array_diff_u*/array_intersect_u*builtins must allow enum case values and pass them to compare callbacks (php-srcext/standard/array.c, unlike plainarray_diff/array_intersectwhich reject enums per php-in-php: array_intersect() enum keys — delete C fast-path, VM Error parity from ext/standard/VmArray.php #5927).array_udiffresults preserve case identity.php-src reference
ext/standard/array.c—php_array_udiff,php_array_uintersect(user callback receives enum zvals)Verification
Output:
Closes #5637
Made with Cursor