Repository navigation
php-in-php: include_path stack compliance + BuiltinExecute on set/get (#3223) - #8006
Merged
Merged
Conversation
…#3223) Add include_path_stack PHPTs, fix file_include_path tests that used ?? (parser gap), and route get/set_include_path through BuiltinExecute so validation and stack updates run even when the return is discarded. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_path_stackVM/JIT compliance PHPTs covering set → include → restore (Stdlib: get_include_path() / set_include_path() / restore_include_path() — include path stack (bootstrap) #3223 bootstrap gate).file_include_path*.phptto avoid??(parser does not lowerExpr_BinaryOp_Coalescein PHPT bodies yet).get_include_path()/set_include_path()throughBuiltinExecute::writeReturnso argc validation and stack mutation always run (Stdlib: VM builtins skip arg validation when return is discarded (returnVar null early-return) #5896 pattern).C runtime: 0 lines added/removed (
phpc_progress.cunchanged — SIGSEGV ABI stub only).php-src reference
ext/standard/basic_functions.c—get_include_path,set_include_path,restore_include_pathmain/php_open_temporary_file.c—PG(include_path)stackVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter include_path'Issue repro (VM):
Closes #3223
Made with Cursor