Repository navigation
php-in-php: VmSockets::atmark FFI-first, drop host socket_atmark preference (#7998) - #7999
Merged
Merged
Conversation
…erence (#7998) Prefer libc sockatmark(3) over Zend ext/sockets delegation when FFI is available; socket_atmark() validates args before void return skip. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmSockets::atmark()now calls libcsockatmark(3)via FFI before any host\socket_atmark()fallback — self-host no longer prefers Zend ext/sockets when FFI is available.socket_atmark()builtin usesBuiltinExecute::writeReturnso socket arg validation runs even when the return is discarded (Stdlib: VM builtins skip arg validation when return is discarded (returnVar null early-return) #5896 pattern).test/unit/VmSocketsRuntimeShrinkTest.php.C runtime: 0 lines added/changed (PHP + libc FFI only).
php-src reference
PHP_FUNCTION(socket_atmark)→sockatmark(2)Verification
Closes #7998
Made with Cursor