Stdlib: utf8_decode() scalar coercion + TypeError parity (#4317) - #7964
Merged
Conversation
utf8_decode() now uses VmString::coerceStringBuiltinArg and JitStringBuiltinArg like utf8_encode(), matching php-src convert_to_string on argument #1. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utf8_decode()VM path now usesVmString::coerceStringBuiltinArg()(php-srcconvert_to_stringon arg Php stdlib specs implementation #1) instead ofLogicExceptionfor non-stringsJitStringBuiltinArg::lower()matchingutf8_encode()utf8_encode()TypeError param name to$stringper php-src stubtest/repro-maintainer/utf8_encode_scalar.phpphp-src reference:
ext/standard/basic_functions.c—PHP_FUNCTION(utf8_encode),PHP_FUNCTION(utf8_decode)Verification
Output:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter utf8_encode_decode_scalar'Closes #4317
Made with Cursor