Compliance: in_array/array_search enum identity parity (#5851, #5592, #5668) - #7920
Merged
Merged
Conversation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in_array()strict/loose andarray_search()strict identity rules (php-src-strict).ext/standard/in_array.php,ext/standard/array_search.php,lib/VM/Variable.php::identicalTo()/equals()); this run locks regression coverage requested by the issues.Closes #5851
Closes #5592
Closes #5668
php-src reference
ext/standard/array.c—php_in_array,php_array_searchwith strict flagZend/zend_operators.c— enum case vs backing scalar never equal (strict or loose)PHP implementation (existing)
ext/standard/in_array.phpidenticalTo, loose vialooseEqualsext/standard/array_search.phplib/VM/Variable.phpidenticalTo/equals(#5798)lib/JIT/ArrayBuiltinHelper.phpinArray/arraySearchloweringC runtime shrink
No new C.
lib/AOT/runtime/remainsphpc_progress.conly.Verification
Output:
Made with Cursor