Stdlib: pack()/unpack() enum operands — warn + backing scalar (#6213, #5713) - #7911
Merged
Merged
Conversation
Route pack() value operands through PackEngine Variable coercion instead of VmJson::export so backed enum cases match Zend: E_WARNING plus backing int round-trip, and string formats Error on enum objects. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pack()no longer routes value operands throughVmJson::export();PackEnginecoercesVariableenum cases with Zend semantics (php-srcext/standard/pack.c).E_WARNING(“Object of class … could not be converted to int/float”) + backing scalar packed.a/A/Z/h/H): enum cases throwError(object-to-string), matching Zend.unpack()enum-as-operandTypeErrorunchanged (Stdlib: unpack() — enum case data/format operands must TypeError not LogicException (ext/standard/pack.c, php-src-strict) #6078 compliance already green).Closes #6213
Related: #5713
php-src reference
ext/standard/pack.c—php_pack()argument coercionPHP implementation
ext/standard/pack.php,ext/standard/PackEngine.php,ext/standard/VmPack.phplib/VM/EnumCaseSupport.php—packCoerceToLong(),packCoerceToDouble(),packRejectStringOperand()Verification
Output (2026-06-10):
Note: full AOT link for
pack()remains blocked by pre-existingStringPackJitLLVM verify failures on master;-llint passes for the enum repro.Made with Cursor