Repository navigation
php-in-php: VmGetrusageNative libc FFI for VM getrusage() (#5388) - #7858
Merged
Merged
Conversation
Route VM getrusage() through VmGetrusageNative (libc getrusage via FFI) instead of host Zend delegation, matching StringGetrusage JIT/AOT and the VmMemory/VmStatNative bootstrap pattern. Normalize who=1 to RUSAGE_CHILDREN in LLVM lowering for php-src parity. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/VmGetrusageNative.php— libcgetrusage(2)via FFI for the VM path, matchingStringGetrusageJIT/AOT field layout and php-srcmicrotime.cwho=1 →RUSAGE_CHILDRENnormalization.VmProcess::getrusage()through native FFI first; host\getrusage()remains only when FFI is unavailable (PHP_COMPILER_DISABLE_FFIor no ext/ffi).who=1before the libc call (php-src parity forgetrusage(1)on Linux).Closes #5388 (VM phase).
php-src reference
ext/standard/microtime.c—PHP_FUNCTION(getrusage)PHP implementation
ext/standard/VmGetrusageNative.php— VM SSOTlib/JIT/Builtin/StringGetrusage.php— JIT/AOT (unchanged ABI, who normalization fix)Verification
Note:
AotTest::testCases getrusagesegfaults on master too (pre-existing AOT execute issue, not introduced here).Made with Cursor