Skip to content

Fix json_encode enum repro/compliance — UnitEnum name clash (#6130) #7801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurHur merged 1 commit into from
Jun 9, 2026
Merged

Fix json_encode enum repro/compliance — UnitEnum name clash (#6130) #7801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/compliance/cases/stdlib/json_encode_enum_case.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
stdlib json_encode() on enum cases matches Zend (issues #6130, #6598)
--FILE--
<?php
enum UnitEnum { case A; }
enum UE { case A; }
enum BackedString: string { case X = 'x'; }
enum BackedInt: int { case One = 1; }

echo 'unit:', json_encode(UnitEnum::A), "\n";
echo 'unit:', json_encode(UE::A), "\n";
echo 'backed_string:', json_encode(BackedString::X), "\n";
echo 'backed_int:', json_encode(BackedInt::One), "\n";
--EXPECT--
Expand Down
16 changes: 16 additions & 0 deletions test/compliance/cases/stdlib/json_encode_enum_case_jit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
--TEST--
stdlib json_encode() JIT — enum cases match Zend (#6130, ext/json/php_json.c)
--JIT--
--FILE--
<?php
enum UE { case A; }
enum BackedString: string { case X = 'x'; }
enum BackedInt: int { case One = 1; }

echo 'unit:', json_encode(UE::A), "\n";
echo 'backed_string:', json_encode(BackedString::X), "\n";
echo 'backed_int:', json_encode(BackedInt::One), "\n";
--EXPECT--
unit:""
backed_string:"x"
backed_int:1
4 changes: 2 additions & 2 deletions test/repro-maintainer/parity_json_encode_enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php

enum UnitEnum { case A; }
enum UE { case A; }
enum BackedString: string { case X = 'x'; }
enum BackedInt: int { case One = 1; }

echo 'unit: ', json_encode(UnitEnum::A), "\n";
echo 'unit: ', json_encode(UE::A), "\n";
echo 'backed_string: ', json_encode(BackedString::X), "\n";
echo 'backed_int: ', json_encode(BackedInt::One), "\n";