Repository navigation
php-in-php: runtime shrink closeout guard (#5211) - #7799
Merged
Merged
Conversation
Consolidates deletion checks for migrated lib/AOT/runtime/*.c TUs into one inventory test; adds enum unserialize roundtrip repro referenced by #5739. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeShrinkCloseoutTest— single inventory guard that the php-in-php queue’s deletedlib/AOT/runtime/*.cfiles stay gone and PHP SSOT paths remain linked.test/repro/issue_enum_unserialize_roundtrip.php(repro cited by Stdlib: unserialize() must restore backed enum case singleton from Zend serialize payload (var_unserializer.c) #5739; green on master).C runtime surface today: only
lib/AOT/runtime/phpc_progress.c(~31 lines, frozen SIGSEGV ABI per #7360). All other migrated TUs are LLVM/PHP inext/+lib/JIT/Builtin/.Closes #5200
Closes #5258
Closes #5278
Closes #5280
Closes #5290
Closes #5363
Closes #5302
Closes #5227
Closes #5234
Closes #5708
Verification
Lines removed (prior merges, inventory)
Made with Cursor