Repository navigation
Stdlib: fputcsv() CSV option ValueError parity (#4530) - #7755
Merged
Merged
Conversation
Add explicit PHP validation for separator/enclosure/escape instead of relying on host fputcsv delegation, matching php-src ext/standard/file.c. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VmCsvArg/JitCsvArgPHP validation forfputcsv()separator, enclosure, and escape arguments matching php-srcext/standard/file.c(PHP_FUNCTION(fputcsv)/php_csv_handle_escape_argument).VmFs::fputcsv()instead of relying on host\fputcsv()delegation.ValueErrorfor invalid option strings.php-src reference
ext/standard/file.c—_php_fputcsv,php_csv_handle_escape_argumentVerification
Closes #4530
Made with Cursor