php-in-php: ext/dom DOMImplementation factory without host DOM (#6140) - #7742
Merged
Merged
Conversation
Implement DOMImplementation::createDocument/createDocumentType/hasFeature and DOMDocument::saveXML in ext/dom/ with PHP-owned node state (DomRegistry). No new C runtime symbols — only Runtime module load wiring. Verification: vendor/bin/phpunit test/unit/DomModuleTest.php test/compliance/DOMImplementationVMTest.php php bin/vm.php test/repro-maintainer/dom_implementation_6140.php Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/dom/module with PHP-owned DOM tree state (DomRegistry,VmDom) — no host\DOM*delegation and no newruntime/*.csymbolsDOMImplementation::createDocumentType,createDocument,hasFeature, andDOMDocument::saveXML+formatOutputpropertylib/Runtime.php; compliance PHPT + unit tests assert Zend parity on the issue reprophp-src reference
ext/dom/php_dom.c—dom_implementation_create_document,dom_implementation_create_document_typeext/dom/VmDom.php,ext/dom/Implementation*.phpC runtime shrink
No C added.
lib/AOT/Linker.phpunchanged (still onlyphpc_progress.cthin ABI).Verification
Output (green):
Closes #6140
Made with Cursor