php-in-php: ext/libxml error buffer — LibXMLError without runtime/*.c (#6058) - #7698
Merged
Merged
Conversation
Implement libxml_use_internal_errors/get_errors/clear_errors and LibXMLError without runtime/*.c growth; wire xml_parse() malformed-input probe to the buffer. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/libxml/module withlibxml_use_internal_errors(),libxml_get_errors(),libxml_clear_errors(), andLibXMLErrorclass — pure PHP ring buffer per php-srcext/libxml/libxml.c.xml_parse()malformed-input probe (ext/xml/VmXml.php) to record errors viaVmLibxml::handleError()for DOM/SimpleXML loader integration later.runtime/orlib/AOT/runtime/; deleted unusedext/xml/XmlFunction.phpstub (29 lines).php-src reference
ext/libxml/libxml.c— internal error toggle + bufferext/libxml/libxml_error.c—LibXMLErrorobject fieldsPHP implementation
ext/libxml/VmLibxml.phpext/libxml/libxml_*.phpext/xml/VmXml.phpVerification
Closes #6058
Made with Cursor