Stdlib: register Zend builtin interfaces UnitEnum/BackedEnum/Serializable (#6354) - #7692
Merged
Merged
Conversation
…6354) Seed internal interface ClassEntry rows at VM init so interface_exists(), get_declared_interfaces(), UnitEnum::class, and is_a() on enum cases match php-src zend_interfaces.c. JIT literal interface_exists gets compile-time seeds. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnitEnum,BackedEnum(extendsUnitEnum), andSerializableinternal interfaces inlib/VM/BuiltinClasses.phpper php-srcZend/zend_interfaces.c.lib/JIT/Builtin/Type/Object_.phpfor literalinterface_exists()lowering.Closes #6354
php-src reference
Zend/zend_interfaces.c—zend_register_internal_interfaceforUnitEnum,BackedEnum,ArrayAccess,Serializablelib/VM/BuiltinClasses.phpVerification
Output (VM/JIT repro):
PHPUnit:
OK (4 tests, 4 assertions)for--filter builtin_interface.AOT
-llint passes; native AOT link remains blocked by pre-existing LLVM verify failures on this harness (same asget_declared_interfacesAOT case).Made with Cursor