Repository navigation
Stdlib: stream_resolve_include_path() + include_path stack (#6051) - #7690
Merged
Merged
Conversation
Implement PHP-in-PHP include_path lookup per ext/standard/streams.c: VmIncludePath stack, get/set/restore_include_path, stream_resolve_include_path with VM + JIT/AOT LLVM lowering (IncludePathRuntime). Wire VmMetaTags and VM include resolution to the shared path. Closes #6051. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_resolve_include_path(),get_include_path(),set_include_path(), andrestore_include_path()in PHP (ext/standard/) with php-src referenceext/standard/streams.c/basic_functions.c.VmIncludePathstack +VmFs::resolveIncludePath()shared byVmMetaTags(no more undefined builtin call) andlib/VM.phpinclude resolution.IncludePathRuntime(__compiler_stream_resolve_include_path, include_path globals).Closes #6051
php-src reference
ext/standard/streams.c—PHP_FUNCTION(stream_resolve_include_path)ext/standard/basic_functions.c—get_include_path/set_include_path/restore_include_pathVerification
Output:
Repro:
Notes
runtime/— include_path state + lookup live inext/+lib/JIT/Builtin/IncludePathRuntime.php.set_include_pathpushes stack entries Zend-style.Made with Cursor