Repository navigation
VM: gc_collect_cycles invokes __destruct on cyclic graphs (#6519) - #7673
Merged
Merged
Conversation
Zend defers destructor invocation on cyclic object graphs until gc_collect_cycles() runs. Call invokeUserDestructor before releasing unreachable objects in CycleCollector (phpc_gc.c already deleted). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zend/zend_gc.c— cyclic graphs defer__destructuntilgc_collect_cycles()lib/VM/CycleCollector.php+lib/VM/ObjectLifetime.phpinvokeinvokeUserDestructor()before releasing unreachable objectsphpc_gc.calready absent on master (deleted in php-in-php: gc_collect_cycles() JIT — delete phpc_gc.c (~368 lines), sweep in lib/VM/CycleCollector.php #5315); this closes the VM behavior gap tracked in php-in-php: phpc_gc.c shutdown destructors — GC cycle collection in lib/VM/Gc.php (Zend/zend_gc.c parity) #6519Verification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter "GcCollectCyclesDestructTest|gc_collect_cycles_destruct"'Output:
Zend baseline (same repro):
Closes #6519
Made with Cursor