Repository navigation
JIT: lower (array)/(object)/(unset) TYPE_CAST_* opcodes (#4887) - #7618
Merged
Merged
Conversation
Wire CastHelper for MCJIT compile of array/object/unset casts; fix LLVM insert-block loss after Object_::allocate() links GC runtime on first object allocation. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/CastHelper.phplowering forTYPE_CAST_ARRAY,TYPE_CAST_OBJECT, andTYPE_CAST_UNSETMCJIT opcodes (Zendzend_operators.c/CastSupportparity).Analyzerescape/static-array coverage for cast expr ops so MCJIT compile does not bail on(object)['x'=>1]/ chained casts.Object_::allocate()first linksGcCollectCyclesRuntime(orphanphpc_gc_registerIR).Verification
Issue repro
count((array)(object)["x"=>1])→1on JIT execute.Closes #4887
Made with Cursor