Repository navigation
Test listSpreadRhs guard without php-cfg overlay (#5472) - #7577
Merged
Merged
Conversation
Add regression test that strips listSpreadRhs from Assign.php and verifies simple assignment compiles without warnings. Guards were already in Compiler.php via assignIsListSpread(); this closes #5472. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignIsListSpread()inlib/Compiler.phpalready guards alllistSpreadRhsreads withproperty_exists()(landed via Language: enum case instanceof user interface — regression vs #3373 (zend_enum.c) #5703/php-in-php: listSpreadRhs php-cfg patch — eliminate compile-time warnings on list()/closure scripts #6069)listSpreadRhsfrom vendorAssign.phpand verifies$a = 1;compiles without warningsVerification
Made with Cursor