Skip to content

Test listSpreadRhs guard without php-cfg overlay (#5472) - #7577

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-5472-list-spread-guard
Jun 7, 2026
Merged

PurHur merged 1 commit into
masterfrom
agent/issue-5472-list-spread-guard

Conversation

@PurHur

@PurHur PurHur commented Jun 7, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php -r "\$a=1;" 2>&1 | grep listSpreadRhs && exit 1 || exit 0'
# exit 0 — no warnings

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter ListSpreadRhsCompileTest'
# OK (4 tests, 8 assertions)

Made with Cursor

Add regression test that strips listSpreadRhs from Assign.php and
verifies simple assignment compiles without warnings. Guards were
already in Compiler.php via assignIsListSpread(); this closes #5472.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bootstrap: php-cfg list-spread overlay missing — Undefined property Assign::$listSpreadRhs warnings (zend_compile.c)

1 participant