Repository navigation
Stdlib: implement stream_isatty() with VM + JIT/AOT lowering (#6035) - #7549
Merged
Merged
Conversation
Add stream_isatty() via VmFs::streamIsatty and thin __compiler_stream_isatty C ABI (isatty/fileno) so TTY detection works on native AOT paths, not VM-only. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_isatty()per php-srcext/standard/streamsfuncs.c— TTY detection for stream resourcesext/standard/stream_isatty.php+VmFs::streamIsatty(); thin C ABI__compiler_stream_isattyinphpc_stream.cusingisatty(fileno(fp))for AOT/JITTypeErrorvia sharedVmStreamArg::requireStreamHandleguards (php-src-strict)Closes #6035
php-src reference
ext/standard/streamsfuncs.c—PHP_FUNCTION(stream_isatty)main/streams/php_stream.c—php_stream_isatty()Verification
Test plan
stream_isatty.phpt— function_exists + false on php://memory and plainfilestream_isatty_enum_typeerror.phpt— enum case → TypeError naming enum classstream_isatty_typeerror.phpt— array operand → TypeErrorstream_isatty| yes | yes | yes)Made with Cursor