Repository navigation
Fix isset()/empty() on property hooks — invoke get hook (#4701) - #7495
Merged
Merged
Conversation
empty($obj->hook) now lowers to TYPE_EMPTY_OBJECT_PROPERTY when php-cfg clears Empty_.expr, and emptyObjectProperty evaluates get-hook truthiness. Nullable get-hook null returns are preserved instead of coercing to "". Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
empty($obj->prop)operand when php-cfg clearsEmpty_.expr, so lowering usesTYPE_EMPTY_OBJECT_PROPERTYlikeisset()usesTYPE_ISSET(zend_property_hooks.c).emptyObjectProperty()on hooked properties now runs the get hook and tests truthiness instead of negating isset semantics.nullfrom get hooks on nullable typed properties (?string) instead of weak-coercing to"".php-src reference
Zend/zend_property_hooks.c— isset/empty on hooked propertiesZend/zend_object_handlers.c—zend_std_has_propertyVerification
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro-maintainer/property_hook_isset.php'Output:
Full compliance case (get-only + null get hook):
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php vendor/bin/phpunit --filter property_hook_isset'Write-only regression:
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php vendor/bin/phpunit --filter property_hook_writeonly_isset'Closes #4701
Made with Cursor