Repository navigation
Language: list destructuring from string — TypeError (#7461) - #7476
Merged
Merged
Conversation
VM TYPE_LIST_UNPACK_CHECK and JIT ListUnpackHelper now reject string operands with zend_execute.c-style message instead of silently binding null slots; null/int/bool/float RHS behavior unchanged (#4325). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_LIST_UNPACK_CHECKinlib/VM.phpthrowsTypeError: Cannot use string as arraywhen list/[]destructuring RHS is a string (Language: list/array destructuring from string — must TypeError not null slots (zend_execute.c) #7461).lib/JIT/ListUnpackHelper.phpmirrors the guard for compile-time and runtime string operands (LLVM TypeErrorRaise path).php-src reference
Zend/zend_execute.c—zend_fetch_dimension_address_read()is_listbranch (PHP 8.4+ warns; issue requires catchableTypeErrorfor string RHS).Verification
Closes #7461
Made with Cursor